Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configurable REMOTE_USER_ENVIRON_NAME #58

Closed
wbclark opened this issue Jan 15, 2020 · 2 comments
Closed

configurable REMOTE_USER_ENVIRON_NAME #58

wbclark opened this issue Jan 15, 2020 · 2 comments

Comments

@wbclark
Copy link
Collaborator

wbclark commented Jan 15, 2020 •
edited
Loading

Fixes #28654

It would be even better if this is a parameter the calling module sets the right parameter to configure it. The reason for that is that now the vhost we deploy by default is insecure since every HTTP client can pass the REMOTE_USER header

Originally posted by @ekohl in #56 (comment)
@wbclark
Copy link
Collaborator Author

wbclark commented Jan 15, 2020

Make the REMOTE_USER_ENVIRON_NAME configurable by the module calling puppet-pulpcore.

@synkd synkd mentioned this issue Jan 30, 2020
Merged
@ekohl
Copy link
Member

ekohl commented Jan 31, 2020

For reference, you can use Fixes GH-58 in the PR body to automatically close issues when merging a PR.

@ekohl ekohl closed this as completed Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ekohl @wbclark