Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package installation in plugin.pp should be option #59

Closed
wbclark opened this issue Jan 15, 2020 · 2 comments
Closed

package installation in plugin.pp should be option #59

wbclark opened this issue Jan 15, 2020 · 2 comments

Comments

@wbclark
Copy link
Collaborator

wbclark commented Jan 15, 2020

In #57 we saw the need to have plugins which can modify configuration without installation an additional package. Before we can implement such a plugin we need to put the package declaration in plugin.pp behind a new parameter, $install_package.

@ekohl
Copy link
Member

ekohl commented Jan 15, 2020

We have https://github.com/theforeman/puppet-pulpcore/blob/master/manifests/plugin.pp#L9. If you have an example where you want to drop a config file but there's no migration then I'd say just using a concat::fragment is better.

@wbclark
Copy link
Collaborator Author

wbclark commented Jan 15, 2020

So, the source of the disconnect here was that I didn't realize there will be an RPM package for the migration. Given that there will be, it shouldn't be necessary to optionally disable the package install logic in plugins at this time. I'll close this issue.

@wbclark wbclark closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants