Skip to content
This repository has been archived by the owner on Nov 5, 2018. It is now read-only.

[websocket] consider message splitting #182

Open
JanKoehnlein opened this issue Oct 2, 2017 · 1 comment
Open

[websocket] consider message splitting #182

JanKoehnlein opened this issue Oct 2, 2017 · 1 comment

Comments

@JanKoehnlein
Copy link
Member

Sometimes the size of a message gets bigger than the maxTextMessageBufferSize of the underlying websocket. On the server, we use MessageHandler.Partial<String> for received messages, but we haven't had a look at sent message so far.

We could use the analogous RemoteEndpoint.Basic.sendText(String, boolean) but that requires synchronized communication. If you mix it with asynchronous communication RemoteEndpoint.Async.sendText(String) you have to be prepared to get IllegalStateExceptions in case they overlap. If we stick to synchronous sending, we might hit performance issues.

The simplest solution seems to be to increase the buffer size, but that's not very universal.

Maybe there are better options?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants