-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[menu] [terminal] align terminal menu with vscode #3356
Comments
I'll add it there as well to view the terminal and align further with vscode thanks! |
About the view menu, I'm not so sure it should go there: |
Just a small questions for my understanding, why terminals are "widgets" and not "views"? I think as a user of Theia I would not know if it's a view or a widget. I understand the concern, but I don't think we should worry too much about that. I'm more concern about the consistency. IMO the user should be able to see all the different IDE main components (debuggers, explorer, terminals, search) from the "View" menu. |
I am mostly neutral about that but I am afraid a Theia user, with a VS Code background, won't appreciate the subtle difference between a singleton and a widget. |
Fixes #3356 - Created new `Terminal` main menu item which encompasses both terminal and task commands - Remove `Task` menu and instead placed the items under the new `Terminal` main-menu - Fixed the ordering of the main-menu items to align with `vscode` Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Thing is, it seems to have been implemented this way to allow split terminals to be placed everywhere in the UI, and not being stuck in only one panel (you can really have terminals everywhere). Which seems good too, but different. Theia views anyway already are different from what VS Code generally does by the fact that despite being singletons, they can be moved around. But it is still not the same thing as what is currently happening with Theia's terminals (because they're standard widgets and not views).
I wouldn't be mad if an "Open New Terminal" command were to land in this menu, although it is a menu for "Views", and the terminal doesn't behave like any other already in that category. @vince-fugnitto can you just add a separator and place the @svenefftinge @akosyakov @kittaakos any takes on this? |
It actually was (is?) my case, but tools can be different. In the current case with the terminals, I wonder what would be better though, is it something that should be changed? |
Fixes #3356 - Created new `Terminal` main menu item which encompasses both terminal and task commands - Remove `Task` menu and instead placed the items under the new `Terminal` main-menu - Fixed the ordering of the main-menu items to align with `vscode` Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Fixes #3356 - Created new `Terminal` main menu item which encompasses both terminal and task commands - Remove `Task` menu and instead placed the items under the new `Terminal` main-menu - Fixed the ordering of the main-menu items to align with `vscode` Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Fixes #3356 - Created new `Terminal` main menu item which encompasses both terminal and task commands - Remove `Task` menu and instead placed the items under the new `Terminal` main-menu - Fixed the ordering of the main-menu items to align with `vscode` Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Fixes #3356 - Created new `Terminal` main menu item which encompasses both terminal and task commands - Remove `Task` menu and instead placed the items under the new `Terminal` main-menu - Fixed the ordering of the main-menu items to align with `vscode` Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Fixes #3356 - Created new `Terminal` main menu item which encompasses both terminal and task commands - Remove `Task` menu and instead placed the items under the new `Terminal` main-menu - Fixed the ordering of the main-menu items to align with `vscode` Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Fixes #3356 - Created new `Terminal` main menu item which encompasses both terminal and task commands - Remove `Task` menu and instead placed the items under the new `Terminal` main-menu - Fixed the ordering of the main-menu items to align with `vscode` Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Fixes #3356 - Created new `Terminal` main menu item which encompasses both terminal and task commands - Remove `Task` menu and instead placed the items under the new `Terminal` main-menu - Fixed the ordering of the main-menu items to align with `vscode` Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Fixes eclipse-theia#3356 - Created new `Terminal` main menu item which encompasses both terminal and task commands - Remove `Task` menu and instead placed the items under the new `Terminal` main-menu - Fixed the ordering of the main-menu items to align with `vscode` Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com> Signed-off-by: Bogdan Stolojan <petre.stolojan@arm.com>
Proposal
Create a new
Terminal
top-parent menu item used for both terminal and task commands.Reasons for Change
vscode
.The text was updated successfully, but these errors were encountered: