Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu] [terminal] align terminal menu with vscode #3356

Closed
vince-fugnitto opened this issue Oct 31, 2018 · 7 comments
Closed

[menu] [terminal] align terminal menu with vscode #3356

vince-fugnitto opened this issue Oct 31, 2018 · 7 comments
Assignees
Labels
proposal feature proposals (potential future features) terminal issues related to the terminal

Comments

@vince-fugnitto
Copy link
Member

Proposal
Create a new Terminal top-parent menu item used for both terminal and task commands.

Reasons for Change

  • Align with vscode.
  • Easier to quickly locate terminal and task commands which are grouped based on functionality.
  • More extensible to add new terminal and task commands than placing them under other menu parents.

selection_004

@vince-fugnitto vince-fugnitto added terminal issues related to the terminal proposal feature proposals (potential future features) labels Oct 31, 2018
@vince-fugnitto vince-fugnitto self-assigned this Oct 31, 2018
@l0rd
Copy link

l0rd commented Oct 31, 2018

What about "Terminal" in View menu (to be even more consistent with VS Code):

image

@vince-fugnitto
Copy link
Member Author

What about "Terminal" in View menu (to be even more consistent with VS Code):

I'll add it there as well to view the terminal and align further with vscode thanks!

@paul-marechal
Copy link
Member

About the view menu, I'm not so sure it should go there:
In Theia, terminals are widgets. Views in Theia are some kind of singleton that usually can be toggled, unlike terminals now. With the way things are, I would feel like just having the Terminal menu should be enough?

@slemeur
Copy link

slemeur commented Oct 31, 2018

Just a small questions for my understanding, why terminals are "widgets" and not "views"?

I think as a user of Theia I would not know if it's a view or a widget. I understand the concern, but I don't think we should worry too much about that. I'm more concern about the consistency. IMO the user should be able to see all the different IDE main components (debuggers, explorer, terminals, search) from the "View" menu.

@l0rd
Copy link

l0rd commented Oct 31, 2018

Views in Theia are some kind of singleton that usually can be toggled, unlike terminals now.

I am mostly neutral about that but I am afraid a Theia user, with a VS Code background, won't appreciate the subtle difference between a singleton and a widget.

vince-fugnitto added a commit that referenced this issue Oct 31, 2018
Fixes #3356

- Created new `Terminal` main menu item which encompasses both terminal and task commands
- Remove `Task` menu and instead placed the items under the new `Terminal` main-menu
- Fixed the ordering of the main-menu items to align with `vscode`

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@paul-marechal
Copy link
Member

paul-marechal commented Oct 31, 2018

Just a small questions for my understanding, why terminals are "widgets" and not "views"?

Thing is, it seems to have been implemented this way to allow split terminals to be placed everywhere in the UI, and not being stuck in only one panel (you can really have terminals everywhere). Which seems good too, but different.

Theia views anyway already are different from what VS Code generally does by the fact that despite being singletons, they can be moved around. But it is still not the same thing as what is currently happening with Theia's terminals (because they're standard widgets and not views).

IMO the user should be able to see all the different IDE main components (debuggers, explorer, terminals, search) from the "View" menu.

I wouldn't be mad if an "Open New Terminal" command were to land in this menu, although it is a menu for "Views", and the terminal doesn't behave like any other already in that category.

@vince-fugnitto can you just add a separator and place the Open New Terminal between all the views and the collapsing commands?

@svenefftinge @akosyakov @kittaakos any takes on this?

@paul-marechal
Copy link
Member

I am mostly neutral about that but I am afraid a Theia user, with a VS Code background, won't appreciate the subtle difference between a singleton and a widget.

It actually was (is?) my case, but tools can be different. In the current case with the terminals, I wonder what would be better though, is it something that should be changed?

vince-fugnitto added a commit that referenced this issue Oct 31, 2018
Fixes #3356

- Created new `Terminal` main menu item which encompasses both terminal and task commands
- Remove `Task` menu and instead placed the items under the new `Terminal` main-menu
- Fixed the ordering of the main-menu items to align with `vscode`

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Nov 1, 2018
Fixes #3356

- Created new `Terminal` main menu item which encompasses both terminal and task commands
- Remove `Task` menu and instead placed the items under the new `Terminal` main-menu
- Fixed the ordering of the main-menu items to align with `vscode`

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Nov 1, 2018
Fixes #3356

- Created new `Terminal` main menu item which encompasses both terminal and task commands
- Remove `Task` menu and instead placed the items under the new `Terminal` main-menu
- Fixed the ordering of the main-menu items to align with `vscode`

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Nov 1, 2018
Fixes #3356

- Created new `Terminal` main menu item which encompasses both terminal and task commands
- Remove `Task` menu and instead placed the items under the new `Terminal` main-menu
- Fixed the ordering of the main-menu items to align with `vscode`

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Nov 2, 2018
Fixes #3356

- Created new `Terminal` main menu item which encompasses both terminal and task commands
- Remove `Task` menu and instead placed the items under the new `Terminal` main-menu
- Fixed the ordering of the main-menu items to align with `vscode`

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Nov 5, 2018
Fixes #3356

- Created new `Terminal` main menu item which encompasses both terminal and task commands
- Remove `Task` menu and instead placed the items under the new `Terminal` main-menu
- Fixed the ordering of the main-menu items to align with `vscode`

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
elaihau pushed a commit that referenced this issue Nov 5, 2018
Fixes #3356

- Created new `Terminal` main menu item which encompasses both terminal and task commands
- Remove `Task` menu and instead placed the items under the new `Terminal` main-menu
- Fixed the ordering of the main-menu items to align with `vscode`

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
bogthe pushed a commit to ARMmbed/theia that referenced this issue Jan 21, 2019
Fixes eclipse-theia#3356

- Created new `Terminal` main menu item which encompasses both terminal and task commands
- Remove `Task` menu and instead placed the items under the new `Terminal` main-menu
- Fixed the ordering of the main-menu items to align with `vscode`

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Signed-off-by: Bogdan Stolojan <petre.stolojan@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal feature proposals (potential future features) terminal issues related to the terminal
Projects
None yet
Development

No branches or pull requests

4 participants