-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create terminal main-menu item #3359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to have view terminal in view menu as well
30748f3
to
5e465be
Compare
@benoitf I meant to tackle having the As @marechal-p mentioned in #3356 we differ from vscode in our implementation of the |
7213ee7
to
0847ccb
Compare
0847ccb
to
aea1e5d
Compare
Fixes #3356 - Created new `Terminal` main menu item which encompasses both terminal and task commands - Remove `Task` menu and instead placed the items under the new `Terminal` main-menu - Fixed the ordering of the main-menu items to align with `vscode` Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
aea1e5d
to
ba6abce
Compare
We should only have singleton views that are toggling their visibility in the view menu. Terminals in Theia are not 'views' in that sense. |
I think we should discuss view menu in another issue/PR |
Fixes #3356
Fixes #2609
Terminal
main menu item which encompasses both terminal and task commandsTask
menu and instead placed the items under the newTerminal
main-menu in their own separated categoryvscode
Reasons for Change
Terminal
and its commands more discoverable for end-usersTerminal
&Tasks
What is not included in the change
Terminal
menu item in theView
main-menuSigned-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com