Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create terminal main-menu item #3359

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Create terminal main-menu item #3359

merged 1 commit into from
Nov 5, 2018

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Oct 31, 2018

Fixes #3356
Fixes #2609

  • Created new Terminal main menu item which encompasses both terminal and task commands
  • Remove Task menu and instead placed the items under the new Terminal main-menu in their own separated category
screen shot 2018-10-31 at 2 23 47 pm
  • Fixed the ordering of the main-menu items to align with vscode
screen shot 2018-10-31 at 2 36 17 pm

Reasons for Change

  • Make the Terminal and its commands more discoverable for end-users
  • Group related items together
  • Align with vscode
  • Easier to add more commands to both Terminal& Tasks

What is not included in the change

  • Adding the Terminal menu item in the View main-menu

Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added the terminal issues related to the terminal label Oct 31, 2018
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have view terminal in view menu as well

@vince-fugnitto
Copy link
Member Author

@benoitf I meant to tackle having the Terminal in the View menu as a separate PR.

As @marechal-p mentioned in #3356 we differ from vscode in our implementation of the Terminal widget. We can spawn multiple terminals and dock them separately in all different locations in Theia.
Because of that, what exactly would the command Terminal in the View widget perform if for instance we had multiple terminals each in different locations? Would you expect an exhaustive search of all docks and widgets to determine which are Terminals and then toggle them?

Fixes #3356

- Created new `Terminal` main menu item which encompasses both terminal and task commands
- Remove `Task` menu and instead placed the items under the new `Terminal` main-menu
- Fixed the ordering of the main-menu items to align with `vscode`

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@svenefftinge
Copy link
Contributor

would be nice to have view terminal in view menu as well

We should only have singleton views that are toggling their visibility in the view menu. Terminals in Theia are not 'views' in that sense.

@benoitf
Copy link
Contributor

benoitf commented Nov 5, 2018

I think we should discuss view menu in another issue/PR

@elaihau elaihau merged commit 22bde9f into master Nov 5, 2018
@elaihau elaihau deleted the refactor-terminal-menu branch November 5, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terminal issues related to the terminal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants