[filesystem] Fixed file dialog opening folder

[federicobozzini]

A file dialog is opened in the folder used as a parameter.

Fixes #4862

[vince-fugnitto]

Should we also align the ElectronFileDialogService?
https://github.com/theia-ide/theia/blob/7d37b1245ab15f91ffdcf8606ffe7b5efe02ba2f/packages/filesystem/src/electron-browser/file-dialog/electron-file-dialog-service.ts#L43

[vince-fugnitto]

Sorry, I see you already updated the Electron version as well 😄

[akosyakov]

Open File menu action should still show the parent directory. We should fix this client, also check whether it makes sense for other existing clients.

[federicobozzini]

Open File menu action should still show the parent directory. We should fix this client, also check whether it makes sense for other existing clients.

Should we? The current behaviour seems different than what I would expect.

At the moment if I click Open File instead of the getting the dialog open in the workspace root, I see it gets opened in the parent folder.

[akosyakov]

As far as I know it was done on purpose: #332 cc @svenefftinge

@federicobozzini please sign your commits and ECA: https://accounts.eclipse.org/users/akosyakov/eca

[svenefftinge]

Should we? The current behaviour seems different than what I would expect.

I did it like that because you probably want to switch to a sibling workspace as this is how many devs organize multiple workspaces locally.

[federicobozzini]

Is this PR accepted? Can it be merged?