Fixed #5543: implemented "show all opened terminals" quick-open command

[fangnx]

Implemented the "Show All Opened Terminals" command in the quick open menu. The command displays all the currently opened terminal widgets, and the user can navigate to each of them by selection and have the option to create a new terminal.

The command has the global prefix: term , to be aligned to VS Code.

The Terminal package may require some refactoring. The terminal-frontend-contribution class seems to include functions that should be otherwise put into a separate class.

[vince-fugnitto]

@lmcbout could you test the PR as well?

[lmcbout]

Currently testing, Putting terminal-# seems repetitive. I can only see one terminal using (_terminal 6) , the others, I see the user path, so hard to match the list of terminal (Quick selection) and the actual terminal . I also notice the same number being used for the terminal (See picture) . Also, How is the number generated, if I open a new terminal, (Small number) and if I run a task, (Number 15, 26. , not even consecutive, why?
What do you think about having a separator between the list of terminals and the "Open new terminal" when there is one or more terminals?

[fangnx]

Currently testing, Putting terminal-# seems repetitive. I can only see one terminal using (_terminal 6) , the others, I see the user path, so hard to match the list of terminal (Quick selection) and the actual terminal . I also notice the same number being used for the terminal (See picture) . Also, How is the number generated, if I open a new terminal, (Small number) and if I run a task, (Number 15, 26. , not even consecutive, why?
What do you think about having a separator between the list of terminals and the "Open new terminal" when there is one or more terminals?

Thanks Jacque! Just found out the sorting logic does not work from your screenshot.

Yes, adding a separator makes sense. The terminal-# is the terminal id. I am not sure why the numbers are not consecutive, but I think since it is difficult to match the terminal-# to the name displayed on the terminal widget, I would use title id (~/theia/.../...) as a label, just as Vince suggested.

[fangnx]

I can't reproduce the repetitive terminal-# issue. How did you get the same terminal-6 when you tested it ;)? @lmcbout

[vince-fugnitto]

@lmcbout do you mind reviewing it again when you get the chance?

[lmcbout]

Minor comments, LGTM

[vince-fugnitto]

@kittaakos could you give it a review as well whenever you get the chance?

[akosyakov]

code wise looks good

if @vince-fugnitto @lmcbout are tested it and happy when please merge it

[lmcbout]

While testing with the latest code ( commit 8e42335 ), I noticed when selecting a terminal (there is a duplication of ID - terminal 4), it selects the first one with the "terminal-4", not the selected one which is the second terminal entry (last entry from the list).

Note the last two entries from the terminal list , both have terminal-4

[vince-fugnitto]

While testing with the latest code ( commit 8e42335 ), I noticed when selecting a terminal (there is a duplication of ID - terminal 4), it selects the first one with the "terminal-4", not the selected one which is the second terminal entry (last entry from the list).

@lmcbout

I don't believe this is an issue with @fangnx code.
I think it's more our current logic is incorrect when assigning terminal ids. Also, when we lookup
terminals by id it makes sense that it returns the first match anyways, so is this really an issue?

[vince-fugnitto]

@lmcbout please open an issue regarding the terminal ids not being unique including steps to reproduce.