Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #5734 correct workspace path variables on windows #5741

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

Vineg
Copy link
Contributor

@Vineg Vineg commented Jul 17, 2019

No description provided.

Signed-off-by: George Vinokhodov <Vineg@yandex.ru>
@Vineg Vineg changed the title fixes theia-ide#5734 correct workspace path variables on windows Fixed #5734 correct workspace path variables on windows Jul 17, 2019
@akosyakov
Copy link
Member

akosyakov commented Jul 18, 2019

Thank you for the contribution, really good change. @Vineg how one can verify correctness?

@akosyakov akosyakov requested review from elaihau and kittaakos July 18, 2019 06:33
@akosyakov akosyakov added the workspace issues related to the workspace label Jul 18, 2019
@Vineg
Copy link
Contributor Author

Vineg commented Jul 18, 2019

@akosyakov I checked that node js simple app configuration such as

{
  // Use IntelliSense to learn about possible attributes.
  // Hover to view descriptions of existing attributes.
  "version": "0.2.0",
  "configurations": [
      {
          "type": "node",
          "request": "launch",
          "name": "Launch Program",
          "program": "${workspaceFolder}/app.js"
      }
  ]
}

starts fine on windows.

It caused

Attribute 'program' does not exist ('{path}').

error before.

@kittaakos
Copy link
Contributor

I am trying this now.

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified the ${workspaceFolder} and ${file} on both Windows and Linux (Gitpod):

  • on Windows, it is broken on the master,
  • and it works as expected with the proposed changes.

👍 Thank you for your help, @Vineg!

@kittaakos
Copy link
Contributor

@akosyakov, any remarks? If no, please press the merge button ;) Thanks!

@kittaakos kittaakos merged commit 87a35c1 into eclipse-theia:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workspace issues related to the workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants