[terminal] add preference to control terminal scrollback #5783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
enhancement
AndrienkoAleksandr
approved these changes
Jul 24, 2019
|
Tested, works fine. |
Fixes #5781 - added new preference `terminal.integrated.scrollback` to control the number of lines the terminal keeps in its buffer - aligned the `values`, `description` and `id` with vscode Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/GH-5781
branch
from
0a08dc0
to
af60c09
Compare
|
CQ has finally been approved. I'll rebase the PR and perform testing before merging. |
|
Confirmed the PR still works correctly, I'll proceed with the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #5781
terminal.integrated.scrollbackto control the number of lines the terminal keeps in its buffervalues,descriptionandidwith vscodeHow to test
terminal.integrated.scrollbackpreference to test different values of scrollback (lines the terminal keeps in its buffer)Review checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com