fix: snippet suggestion does not replace the input string

[yeweiasia]

What it does

fix #5926: snippet suggestion does not replace the input string

• a CQ for copied code: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20668 (please mark when it is resolved or labeled with checkin ready

How to test

1.theia 0.9.0 with redhat.java-0.46.0.vsix
2.open a maven project and edit a java file
3.type keyword like "if".

4.select "ifelse" or other snippet suggestion.
5.without this patch whole suggested item body will be append to "if" which is demonstrated in #5926

6.with this patch "if" will replaced by suggested item body.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[yeweiasia]

#5926

[vince-fugnitto]

@yeweiasia can you provide comment on the PR template, mainly 'what it does' and 'how to test'?

[yeweiasia]

@vince-fugnitto comment updated

[akosyakov]

You can have a look how VS Code does it here: https://github.com/TypeFox/vscode/blob/monaco/0.18.0/src/vs/workbench/contrib/snippets/browser/snippetCompletionProvider.ts#L80-L140

[yeweiasia]

ok, I will investigate how vscode implemented in next few days.

[JanKoehnlein]

This definitely fixes the buggy behavior described in the issue, but I am inclined we should do more sophisticated word-wise matching as VS Code does.

[yeweiasia]

@akosyakov PR updated.

[akosyakov]

@yeweiasia Does it address #4208 as well? Could you update the description with fix if so.

[akosyakov]

I've updated a description with a link to the CQ.

[yeweiasia]

@akosyakov I think this can be implemented in my own way, I will rewrite and make another PR to resolve this bug

[yeweiasia]

@yeweiasia Does it address #4208 as well? Could you update the description with fix if so.

I will test after rewriting

[akosyakov]

@akosyakov I think this can be implemented in my own way, I will rewrite and make another PR to resolve this bug

What for? It will make it harder to keep in sync for future updates. We can wait for a CQ.

[yeweiasia]

@akosyakov I have implemented another version of this feature, #5963
that version is more concise when dealing with pattern, I just find out the word at the cursor position rather than find out all offsets of the word in whole line. I think find out all word in whole line make no sense in case of snippet code suggestion.
for #4208, I have test the latest version of groovy plugin 0.1.2, I am not able to reproduce the problem mentioned in the issue. typing "thr" will not trigger auto completion , by searching the repository of code-groovy, no snippet named "thread" can be found.

[akosyakov]

@yeweiasia if you are sure that your implementation is better than let's go with it. We can reconsider later to use VS Code implementation if it will be required. Please close this PR then.

[yeweiasia]

@akosyakov after trying to provide another implementation, It seems better to sync with vscode logic and I have fully synced with vscode impl :)

[akosyakov]

@yeweiasia at least we've learned why it is implemented so 👍

@BroKun @vince-fugnitto Could you finish the review on this PR please?

[akosyakov]

CQ was marked as ready for checkin, @BroKun @vince-fugnitto please merge if you are happy after testing

[BroKun]

It works nicely, @yeweiasia thanks :)