Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress indicator to Search #5980

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Add progress indicator to Search #5980

merged 1 commit into from
Aug 20, 2019

Conversation

AlexTugarev
Copy link
Contributor

@AlexTugarev AlexTugarev commented Aug 19, 2019

2019-08-19 11 08 02

What it does

Adds indefinite progress bar to search view.

Fixes #5957

How to test

  • use the search feature

Review checklist

Reminder for reviewers

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well and looks very good :)
I'll give others a chance to try it out as well.


As a side note, I believe the author check in the PR template was not checked yet.

Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely!

@AlexTugarev AlexTugarev merged commit 3f146a0 into master Aug 20, 2019
@AlexTugarev AlexTugarev deleted the at/siw-progress branch August 20, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show progress in Search view
3 participants