Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core functionality to default intern export #1120

Open
jason0x43 opened this issue Mar 11, 2020 · 1 comment
Open

Add core functionality to default intern export #1120

jason0x43 opened this issue Mar 11, 2020 · 1 comment
Labels
effort-low Should be pretty quick enhancement A new or improved feature priority-high Most important

Comments

@jason0x43
Copy link
Member

jason0x43 commented Mar 11, 2020

Core functionality, such as the built in test interfaces and assertions, should be available to import through the base Intern export.

import { describe, it } from 'intern';
describe('something', () => { ... });

At least the test interfaces (object, bdd, tdd), assert, and expect should be exported. The implementer should also verify that the necessary types are exported so that the package is usable when installed.

See #1041 for discussion

@jason0x43 jason0x43 added enhancement A new or improved feature effort-low Should be pretty quick priority-medium This should get done, but it's not a high priority labels Mar 11, 2020
@jason0x43 jason0x43 added priority-high Most important and removed priority-medium This should get done, but it's not a high priority labels Apr 7, 2020
@jason0x43 jason0x43 changed the title Add core functionality to base intern package Add core functionality to default intern export Apr 14, 2020
@jason0x43
Copy link
Member Author

Another reason for this -- when directly importing interfaces, you'll end up building parts of intern into tests. That can lead to subtle issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort-low Should be pretty quick enhancement A new or improved feature priority-high Most important
Projects
None yet
Development

No branches or pull requests

1 participant