Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Leadfoot to TypeScript #96

Closed
morrinene opened this issue Nov 4, 2016 · 2 comments
Closed

Migrate Leadfoot to TypeScript #96

morrinene opened this issue Nov 4, 2016 · 2 comments
Assignees
@nicknisi
Labels
d-hard enhancement
Milestone
Leadfoot 2.0

Comments

@morrinene
Copy link

morrinene commented Nov 4, 2016 •
edited
Loading

As part of the ES6/TS refactor, we are migrating Leadfoot to TypeScript.  This issue will cover the conversion and test updates needed.

Be sure to take into consideration work done for the Intern Migration: theintern/intern#674
@morrinene morrinene modified the milestones: Milestone 4, 1.7 Nov 4, 2016
@nicknisi nicknisi mentioned this issue Dec 5, 2016
Closed
@nicknisi
Copy link
Member

nicknisi commented Jan 9, 2017

I have removed the CancelablePromise class from the project, and switched everything to use Task instead after discussing with @jason0x43 the necessity of a cancelled Promise to throw a CancelError. The tests run and pass, but the unit tests are throwing an error when run along with the functional tests.

@jason0x43
Copy link
Member

The refactor is now in master (f9c492a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicknisi nicknisi

Labels
d-hard enhancement
Projects
None yet
Milestone
Leadfoot 2.0
Development

No branches or pull requests
3 participants
@nicknisi @jason0x43 @morrinene