Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanliness #3

Closed
nils-werner opened this issue Sep 21, 2021 · 1 comment
Closed

Code cleanliness #3

nils-werner opened this issue Sep 21, 2021 · 1 comment
Assignees
@thejasvibr
Labels
documentation Improvements or additions to documentation

Comments

@nils-werner
Copy link

Hi, this issue is related to your submission to JOSS, #3740.

I have noticed that your codebase has a lot of commented out code blocks:

Also, many of your files have Jupyter/VS Code notebook cell makers, like

# %%

I understand that in many situations, library code evolves from experimental notebook-code, but I would still like to suggest to give the codebase a proper cleanup before publication.
@thejasvibr thejasvibr self-assigned this Sep 22, 2021
@thejasvibr thejasvibr added the documentation Improvements or additions to documentation label Sep 22, 2021
@thejasvibr
Copy link
Owner

#%% symbols and commented out code portions deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thejasvibr thejasvibr

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nils-werner @thejasvibr