Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs are very terse #7

Closed
nils-werner opened this issue Sep 21, 2021 · 4 comments
Closed

Docs are very terse #7

nils-werner opened this issue Sep 21, 2021 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@nils-werner
Copy link

Hi, this issue is related to your submission to JOSS, #3740.

I have noticed the docs for your library are very terse. While you do have a section that roughly explains the concept of a directivity pattern, you very quickly dive into technicalities like parameters and specific patterns. This makes it really hard for people inside and outside of your field to quickly understand the purpose of this library and what problems it solves.

I would recommend expanding on these sections, using more text and simpler language.

Also, the implemented directivity patterns are only listed by name and a single figure each. Just from these figures, I was unfortunately not able to understand the actual shape and its properties. Again, I would recommend expanding on these sections, and maybe more figures.

@thejasvibr thejasvibr self-assigned this Sep 22, 2021
@thejasvibr thejasvibr added the documentation Improvements or additions to documentation label Sep 22, 2021
@hagenw
Copy link

hagenw commented Oct 15, 2021

I agree and would also recommend to improve the introduction of the package.

@thejasvibr
Copy link
Owner

As of 52d8021 Have worked on adding brief model descriptions and background on their meaning.

Hope this version of the docs is clearer and provides more background?

@faroit
Copy link
Contributor

faroit commented Dec 6, 2021

@nils-werner are these changes sufficient?

@nils-werner
Copy link
Author

Yes, the docs are much better now, thanks! (you could also link to them in your repo settings)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants