-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comments in config file #1
Conversation
Looks good to me |
Yep, lgtm too. |
@@ -30,7 +30,7 @@ module.exports = { | |||
// Set the local IP to bind to. | |||
// | |||
// @type string | |||
// @default "0.0.0.0" | |||
// @default undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this perhaps explain what undefined means in this context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's probably a good plan. Just a short explanation that undefined means it'll listen on everything.
Hey @FryDay, could you get rid of the merge commit in the history please? Let me know if you don't know how to do that and we can sync on IRC. In the future, when you want to sync with master, always use Thanks a lot for fixing cruft!!! 😄 |
@astorije certainly, I'll take care of it tonight when I get home. |
Perfect :-) |
@astorije I believe I fixed it. If it doesn't look okay, let me know. |
I'm 👍 on this, going for second review (as there were changes after @YaManicKill's comment). |
👍 I'm fine with teh 2 commits because they are both doing logically seperate things. Merging. |
Fix comments in config file
Updates fork
Some of the defaults in the comments do not match the actual default values.