Fix CSS selector syntax in channel message handler #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't do much, but it prevents unneeded exceptions which are annoying when debugging.
maxpoulin64
added
Type: Bug
|
👍 |
astorije
added a commit
that referenced
this pull request
Feb 25, 2016
Fix CSS selector syntax in channel message handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't do much, but it prevents unneeded exceptions which are annoying when debugging. This makes the selector valid. An exception is thrown on every single message sent to any channel, so when you have a lot of them the debugger endlessly pauses for nothing.
It might also possibly improve performance slightly as jQuery won't have to fallback to its own implementation (but don't quote me on that).