Use irc-framework setTopic() for topic command #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
reviewed
Apr 24, 2017
src/plugins/inputs/topic.js
Outdated
| var irc = network.irc; | ||
| irc.raw("TOPIC", chan.name, args.join(" ")); | ||
|
|
||
| client.setTopic(chan.name, args.join(" ")); |
There was a problem hiding this comment.
client is more clear imo, also consistent with other files, but nbd to change
There was a problem hiding this comment.
Need to change on L10/R11 as well then. I'll approve after that and let @xPaw decide if he cares or not.
|
Actually got on the laptop and fixed it. Good now. |
|
Did you test that |
AlMcKinlay
approved these changes
Apr 25, 2017
|
Still works, @xPaw |
astorije
added
the
Type: Feature
astorije
approved these changes
Apr 25, 2017
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Use irc-framework setTopic() for topic command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible due to #1070