Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix complete crash when refreshing a public instance #125

Merged
merged 1 commit into from
Feb 29, 2016

Conversation

astorije
Copy link
Member

This fixes #124. The Client constructor was changed in #57, but was used twice and updated only in one place.
Removed global reference to sockets as it's not needed anymore. I tested and did not find any new stuff breaking, but reviews will confirm.

Marking as priority as releases are on hold until #124 is fixed in master.

@astorije astorije added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. priority labels Feb 29, 2016
@maxpoulin64 maxpoulin64 self-assigned this Feb 29, 2016
@maxpoulin64
Copy link
Member

Ouch. 👍

@xPaw
Copy link
Member

xPaw commented Feb 29, 2016

@astorije
Copy link
Member Author

@xPaw, yes, because Client still has a reference to the sockets as part of the constructor: https://github.com/thelounge/lounge/blob/5f11c262236078a8d671b5fbdb515de02a0671e5/src/client.js#L60
Now we can wonder if it's useful to have both around, but this is a quick bug fix to fix the master branch, I don't think I should refactor other things in this PR.

@xPaw
Copy link
Member

xPaw commented Feb 29, 2016

I was asking in case that needed to be changed. 👍

@astorije
Copy link
Member Author

Yeah, that was the starting point of my debugging, but quickly found the actual culprit later :-)
That being said, do you want me to get rid of the sockets in the Client model in a further PR? I'd say we'll clean this up over time anyway, but you pick.

@xPaw
Copy link
Member

xPaw commented Feb 29, 2016

Either is fine. Merging this.

xPaw added a commit that referenced this pull request Feb 29, 2016
Fix complete crash when refreshing a public instance
@xPaw xPaw merged commit 70de3de into master Feb 29, 2016
@xPaw xPaw deleted the astorije/124-fix-crash branch February 29, 2016 20:42
@astorije astorije added this to the 1.3.0 milestone Apr 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server crashes when reloading the page on a public instance
3 participants