Fix time placeholder showing on mobile format for condensed messages #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
the
Type: Bug
|
👍 tested and can confirm it works |
xPaw
requested changes
Aug 23, 2017
client/views/msg_condensed.tpl
Outdated
| <div class="msg {{type}} closed" data-time="{{time}}"> | ||
| <span class="time hide-text">{{tz time}}</span> | ||
| <div class="msg condensed closed"> | ||
| <span class="time">00:00</span> |
There was a problem hiding this comment.
This will break layout with seconds enabled
There was a problem hiding this comment.
Yes, I'm stupid. Goddammit, I was so hoping this was the right better thing... So should I just leave actual time as is, for now? :/
There was a problem hiding this comment.
Alright, fixed. Well, at least you can't select it by accident anymore...
As an extra, make sure time placeholder cannot be selected anymore, and do not do an extra call to `tz` helper when time is not relevant/displayed. I tried to entirely remove `time`/`from` blocks, but because of flexbox layout, that broke message alignment...
astorije
force-pushed
the
astorije/fix-condensed-time
branch
from
18671a5
to
51bd46b
Compare
xPaw
approved these changes
Aug 23, 2017
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…ed-time Fix time placeholder showing on mobile format for condensed messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/Cc @MaxLeiter
As an extra, make sure time placeholder cannot be selected anymore,
and do not do an extra call to.tzhelper when time is not relevant/displayedI tried to entirely remove
time/fromblocks, but because of flexbox layout, that broke message alignment...