Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening first channel on server start #1549

Merged
merged 1 commit into from
Sep 21, 2017
Merged

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Sep 20, 2017

Fixes #1547. Auto reconnect PR broke this behaviour, so I'm bringing it back.

@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Sep 20, 2017
@xPaw xPaw added this to the 2.5.0 milestone Sep 20, 2017

// Open last active channel
if (clientActive > 0) {
target = sidebar.find("[data-id='" + clientActive + "']");
}

// Open window provided in location.hash
if (!target && window.location.hash) {
if (!target.length > 0 && window.location.hash) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=== 0
Same below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of !...> 0 I mean

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it.

Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@astorije astorije merged commit e165d51 into master Sep 21, 2017
@astorije astorije deleted the xpaw/fix-default-chan branch September 21, 2017 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants