-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix opening first channel on server start #1549
Conversation
client/js/socket-events/init.js
Outdated
|
||
// Open last active channel | ||
if (clientActive > 0) { | ||
target = sidebar.find("[data-id='" + clientActive + "']"); | ||
} | ||
|
||
// Open window provided in location.hash | ||
if (!target && window.location.hash) { | ||
if (!target.length > 0 && window.location.hash) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=== 0
Same below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of !...> 0 I mean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it.
091f664
to
649e9c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
Fixes #1547. Auto reconnect PR broke this behaviour, so I'm bringing it back.