Add dummy method to forms (quiets LastPass) #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears LastPass looks for the use of the GET method in forms on the page to determine if it is secure or not. Since Shout never actually submits any of the forms, no method is set, which means the default of GET is used. Changes form methods to POST to quiet the warning. Should fix thelounge#648
astorije
added
the
Type: Bug
|
Thanks a lot for this! |
|
@astorije Does that mean you 👍 it? I'll give this a 👍 as well, so merge if you want, but I won't until you officially give it one :-P |
|
👍 This is fine. |
|
Oops, sorry @YaManicKill, I was tired ^^ |
astorije
added a commit
that referenced
this pull request
Feb 13, 2016
Add dummy method to forms (quiets LastPass)
brunnre8
pushed a commit
to brunnre8/thelounge
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears LastPass looks for the use of the GET method in forms on the page to determine if it is secure or not. Since Shout never actually submits any of the forms, no method is set, which means the default of GET is used. Changes form methods to POST to quiet the warning. Should fix erming/shout#648.