Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement /list #258

Merged
merged 2 commits into from
Sep 29, 2016
Merged

Implement /list #258

merged 2 commits into from
Sep 29, 2016

Conversation

maxpoulin64
Copy link
Member

This re-adds @xPaw's /list implementation, with additional styling to make it look nice.

capture d ecran_2016-04-16_08-33-26

@maxpoulin64 maxpoulin64 added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Apr 16, 2016
@MaxLeiter MaxLeiter mentioned this pull request Apr 16, 2016
Closed
@xPaw xPaw mentioned this pull request Apr 16, 2016
Closed
@xPaw
Copy link
Member

xPaw commented Apr 17, 2016

👍

Just wondering, will our tab complete "Channel list" due to #64?

@xPaw xPaw added second review needed Meta: Do Not Merge This PR should not be merged. labels Apr 17, 2016
@xPaw
Copy link
Member

xPaw commented Apr 20, 2016 •
edited
Loading

I've added do not merge label on this PR for now. Ideally we need some list safe guards in irc-fw for this to work nicely.

@maxpoulin64 maxpoulin64 force-pushed the channel-list branch 2 times, most recently from 77f33ca to b003988 Compare May 29, 2016 02:12
@maxpoulin64
Copy link
Member Author

@xPaw: I just made a PR in irc-framework fixing the crash, and added a few safeguards on our end as well to avoid issues.

Turns out the W3C's IRC server violates the IRC standards... Because clearly, they're very good at dealing with standards.

@xPaw xPaw removed the Meta: Do Not Merge This PR should not be merged. label Jul 2, 2016
@xPaw
Copy link
Member

xPaw commented Jul 2, 2016 •
edited
Loading

@maxpoulin64 irc-fw PR merged, could you rebase this?

@maxpoulin64
Copy link
Member Author

@xPaw rebased

@xPaw xPaw added this to the Next Release milestone Jul 4, 2016
@MaxLeiter
Copy link
Member

Bump?

maxpoulin64 and others added 2 commits July 22, 2016 21:42
@maxpoulin64
Copy link
Member Author

@astorije: just rebased again. This one should be ready to be merged since major bugs have been fixed in irc-fw.

@astorije
Copy link
Member

Somehow I was picturing this as a do not merge, not sure why. I'll play with it ASAP :-)

@astorije astorije self-assigned this Jul 23, 2016
@MaxLeiter
Copy link
Member

Testing this - do we want 'Loading channel list, this can take a moment...' to stay at the top of the channel buffer once its loaded? (example visible in first screenshot)

@astorije astorije added the Meta: Do Not Merge This PR should not be merged. label Sep 18, 2016
@astorije
Copy link
Member

Testing this - do we want 'Loading channel list, this can take a moment...' to stay at the top of the channel buffer once its loaded?

I'm in favor of removing it from the buffer after loading, if (easily) possible.

@astorije astorije removed the Meta: Do Not Merge This PR should not be merged. label Sep 28, 2016
@MaxLeiter
Copy link
Member

I think my comment above can be addressed in another PR; I think this is fine to merge

@astorije astorije merged commit 345aac1 into thelounge:master Sep 29, 2016
@astorije astorije mentioned this pull request Sep 29, 2016
Closed
@astorije astorije modified the milestones: 2.1.0, Next Release Sep 29, 2016
astorije added a commit that referenced this pull request Sep 30, 2016
@astorije
Fix title icons for channels and channel lists
f2c4d08 
This bug slipped when adding `/list` support in #258.
@astorije astorije mentioned this pull request Sep 30, 2016
Merged
astorije added a commit to nornagon/lounge that referenced this pull request Oct 23, 2016
@astorije
Fix title icons for channels and channel lists
eed814e 
This bug slipped when adding `/list` support in thelounge#258.
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
@astorije
Merge pull request thelounge#258 from maxpoulin64/channel-list
7399e44 
Implement /list
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
@astorije
Fix title icons for channels and channel lists
ee14cfc 
This bug slipped when adding `/list` support in thelounge#258.
@maxpoulin64 maxpoulin64 deleted the channel-list branch February 5, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

Assignees

@astorije astorije

Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@maxpoulin64 @xPaw @MaxLeiter @astorije