Add missing aria-label on icon buttons #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
the
Type: Feature
This was referenced May 7, 2016
|
Did you forget the Other than that, 👍 |
|
Done, thanks @maxpoulin64. Although... The sidebar is probably not accessible at all at the moment (I couldn't access it with VoiceOver, but maybe I'm not used to this software enough yet). |
astorije
force-pushed
the
astorije/aria-label-on-buttons
branch
from
2d34a32
to
705f3d1
Compare
| </footer> | ||
| <div id="main"> | ||
| <div id="windows"> | ||
| <div id="chat" class="no-colors"></div> | ||
| <div id="sign-in" class="window"> | ||
| <div class="header"> | ||
| <button class="lt"></button> | ||
| <button class="lt" aria-label="Toggle menu"></button> |
There was a problem hiding this comment.
Change Toggle menu to Toggle channel list or Toggle sidebar.
astorije
force-pushed
the
astorije/aria-label-on-buttons
branch
from
705f3d1
to
57d7b01
Compare
|
🚢 |
|
@xPaw told me he was 👍 on IRC. Merging (after tests pass :p). |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…n-buttons Add missing aria-label on icon buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing #296. Let me know if wording is off.