Update irc-framework #324
Merged
Update irc-framework #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -182,6 +183,7 @@ Client.prototype.connect = function(args) { | |||
| } else { | |||
| webirc = { | |||
| password: config.webirc[network.host], | |||
| username: network.username, | |||
There was a problem hiding this comment.
I think webirc usernames are for the client itself, not to identify the user. Probably would need to update the config format so it takes a username and password instead of just a password. Thoughts on that?
There was a problem hiding this comment.
Sounds like it. https://kiwiirc.com/docs/webirc
There was a problem hiding this comment.
Any reason not to default to something like lounge?
There was a problem hiding this comment.
@dgw: We could, but it needs to be user changeable in case a server provides a username and password. So far the ircd I use for testing doesn't even use the username, but since it's in the spec we should implement it right.
Closed
astorije
added
Type: Feature
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Update irc-framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.