Fix #30: Close channel on the client as soon as close event is registered

[xPaw]

This is my proposed fix to the issue, unsure if there is a better way of doing it.

[maxpoulin64]

Seems reasonable to me. In theory IRC is over TCP, and in theory servers should let you part channels so that seems fine. I think most (all?l clients just close the tab immediately and leave the part as a background job, dropping messages (the user doesn't want it, right?). The existance of the channel is checked, so if the server is stubborn the channel will just reopen as a query.

[astorije]

@xPaw, tested locally and I can indeed "close" (aka remove from the list) the channel, but still receives a red "You're not on that channel" on the server window. Any way we can avoid that easily?

[maxpoulin64]

I don't think so. It looks like a generic server error message, likely triggered by the extra part command.

Maybe we could add state tracking to chan.js instead to avoid leaving a channel twice?

[astorije]

Ping @xPaw? :-)

[xPaw]

@astorije, @maxpoulin64 is right. You will get an error for trying to leave a channel you're not in, but that's about it. Adding state tracking for channels would require quite a bit more code.

[astorije]

You will get an error for trying to leave a channel you're not in, but that's about it.

OK then, seems good enough to me.

Adding state tracking for channels would require quite a bit more code.

Clearly out of scope for this PR and definitely needs some discussion/design before jumping into coding that, so good enough for me. At least this fixes the original bug without adding a new one :-)

👍 and merging as-is, no second review needed per the review process as @xPaw is a reviewer himself, the PR is minor and it's simply a bug fix.