Send user to lobby of deleted chan when parting from active chan #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
Type: Bug
Instead of always sending them back to the very first lobby on the app. This fixes a bug introduced in recent layout change but does not bring previous behavior back: When closing active channel, user gets sent to lobby instead of previously visited channel.
astorije
force-pushed
the
astorije/fix-parting
branch
from
e3dabe1
to
c9d4513
Compare
|
Looks good to me, merging. Will open a new PR with my fix to bring back the history/ordering. |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Send user to lobby of deleted chan when parting from active chan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #485.
Instead of always sending them back to the very first lobby on the app.
This fixes a bug introduced in recent layout change (#465) but does not bring previous behavior back: when closing active channel, user gets sent to lobby instead of previously visited channel.
Many ways (at least three) of bringing this back were discussed on the channel but: 1) fixing the bug to an acceptable state is priority, 2) usage might show it's not necessary. Trying this at first keeps the code simple, we'll see if necessary later.
I have done some quick tests but encourage the reviewer(s) to do some more :-)