Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow long URLs to break onto next line on Chrome #576

Merged
merged 1 commit into from
Aug 21, 2016

Conversation

astorije
Copy link
Member

Fixes #550.

This fixes a bug that displays a horizontal scrollbar and messes up with the layout when URLs (or text) is too long.
Fix is Chrome-specific but so is the bug.

It is possible that #523 fixes this along the way, but it looks like it may be creating some other issues. Therefore it needs cautious testing and maybe some tweaking, hence delays, while this PR fixes now this specific bug in the meantime.

Result

Before After
screen shot 2016-08-19 at 23 32 50 screen shot 2016-08-19 at 23 32 15

This fixes a bug that displays a horizontal scrollbar and messes up with the layout when URLs (or text) is too long.
Fix is Chrome-specific but so is the bug.
@astorije astorije added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. second review needed labels Aug 20, 2016
@astorije astorije added this to the 2.0.0 milestone Aug 20, 2016
@xPaw
Copy link
Member

xPaw commented Aug 20, 2016

👍

@astorije astorije merged commit ed9c257 into master Aug 21, 2016
@astorije astorije deleted the astorije/550-fix-long-urls branch August 21, 2016 05:34
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
…-urls

Allow long URLs to break onto next line on Chrome
@xPaw xPaw removed their assignment Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long URLs overflow the chat window and create a transparent yet present horizontal scrollbar
2 participants