Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simplified way to invite a user in the current channel #76

Merged
merged 1 commit into from
Feb 20, 2016

Conversation

astorije
Copy link
Member

This relates to #7 (comment).

@astorije astorije added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Feb 20, 2016
@astorije
Copy link
Member Author

Now that I think of it, I need to make sure that this is only possible in channels, not lobbies or private messages.
I'll give it another test and run tomorrow!

@astorije astorije force-pushed the astorije/invite-current-channel branch from 5082134 to eb794ab Compare February 20, 2016 16:32
@astorije
Copy link
Member Author

Indeed, I needed an extra check. @xPaw or any other reviewer, this is good to go, and I'll let the first reviewer decide if this needs an additional review.

@xPaw
Copy link
Member

xPaw commented Feb 20, 2016

👍 Next step is showing a message like "You invited xxx to #yyy" :)

@astorije
Copy link
Member Author

Yep, but not in this PR, correct?
Also, do you want to merge this now or prefer a second review?

@xPaw
Copy link
Member

xPaw commented Feb 20, 2016

Yes another pr is fine. Change is small enough not to warrant a second review.

astorije added a commit that referenced this pull request Feb 20, 2016
Add a simplified way to invite a user in the current channel
@astorije astorije merged commit 5edd825 into master Feb 20, 2016
@astorije astorije deleted the astorije/invite-current-channel branch February 20, 2016 16:37
@astorije astorije assigned xPaw and unassigned xPaw Feb 25, 2016
@astorije astorije added this to the 1.2.0 milestone Apr 1, 2017
@xPaw xPaw removed their assignment Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants