-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webpack to the latest version 🚀 #905
Conversation
We're affected by the breaking change mentioned here
|
Does someone want to give a shot at migrating our config? @nornagon, are you willing to come back to us? :D |
b7bb9b8
to
d7a20a0
Compare
From the channel:
|
d7a20a0
to
299bdb4
Compare
I've updated config according to the migration guide. |
299bdb4
to
e0111ed
Compare
@@ -66,13 +70,11 @@ let config = { | |||
// ********************************* | |||
|
|||
if (process.env.NODE_ENV === "production") { | |||
config.plugins.push(new webpack.optimize.DedupePlugin()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, why did you remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer needed. https://webpack.js.org/guides/migrating/#dedupeplugin-has-been-removed
})); | ||
} else { | ||
console.log("Building in development mode, bundles will not be minified."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Building for non-production, [...]"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds rather weird worded this way, imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed but saying this is not production more accurate as we also have test env, etc.. Oh well, nitpick.
….2.1 Update webpack to the latest version 🚀
Version 2.2.1 of webpack just got published.
The version 2.2.1 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of webpack.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 1559 commits (ahead by 1559, behind by 66).
0445b15
2.2.1
ce5b72a
Merge pull request #4124 from willmendesneto/refactor-critical-dependency-warning
54b6f38
Merge pull request #4127 from li-kai/uglify-plugin-test
cadc025
Merge pull request #4133 from hlwsmith/patch-1
2ed6448
Fix link to Vue framework
deabd23
Fix naming
a417b80
Add test for UglifyJsPlugin
1e56bb5
refactor(CriticalDependencyWarning): upgrade to ES6
873aad1
Merge pull request #3887 from shubheksha/refactor-CommonJsPlugin
1caeb72
refactor(ES6): upgrade CommonJsPlugin to ES6
68dea37
Merge pull request #4043 from shubheksha/refactor-test-RecordIdsPlugin
0460726
Merge pull request #4049 from shubheksha/refactor-test-Template
22352b8
Merge pull request #4047 from shubheksha/refactor-test-SourceMapDevToolModuleOptionsPlugin
58b4b55
Merge pull request #4044 from shubheksha/refactor-test-RequireJsStuffPlugin
5df1d5c
Merge pull request #4034 from carloscuatin/refactor-eval-dev-tool-module-template-plugin
There are 250 commits in total. See the full diff.
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴