Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack to the latest version 🚀 #905

Merged
merged 1 commit into from
Feb 18, 2017

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jan 30, 2017

Version 2.2.1 of webpack just got published.

Dependency webpack
Current Version 1.14.0
Type devDependency

The version 2.2.1 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of webpack.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Commits

The new version differs by 1559 commits (ahead by 1559, behind by 66).

  • 0445b15 2.2.1
  • ce5b72a Merge pull request #4124 from willmendesneto/refactor-critical-dependency-warning
  • 54b6f38 Merge pull request #4127 from li-kai/uglify-plugin-test
  • cadc025 Merge pull request #4133 from hlwsmith/patch-1
  • 2ed6448 Fix link to Vue framework
  • deabd23 Fix naming
  • a417b80 Add test for UglifyJsPlugin
  • 1e56bb5 refactor(CriticalDependencyWarning): upgrade to ES6
  • 873aad1 Merge pull request #3887 from shubheksha/refactor-CommonJsPlugin
  • 1caeb72 refactor(ES6): upgrade CommonJsPlugin to ES6
  • 68dea37 Merge pull request #4043 from shubheksha/refactor-test-RecordIdsPlugin
  • 0460726 Merge pull request #4049 from shubheksha/refactor-test-Template
  • 22352b8 Merge pull request #4047 from shubheksha/refactor-test-SourceMapDevToolModuleOptionsPlugin
  • 58b4b55 Merge pull request #4044 from shubheksha/refactor-test-RequireJsStuffPlugin
  • 5df1d5c Merge pull request #4034 from carloscuatin/refactor-eval-dev-tool-module-template-plugin

There are 250 commits in total. See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

@greenkeeper greenkeeper bot added the Type: Dependencies Automatic updates for dependencies, managed by Renovate. label Jan 30, 2017
@MaxLeiter
Copy link
Member

We're affected by the breaking change mentioned here

-loader is no longer automatically added when resolving loaders

@Bonuspunkt
Copy link
Contributor

@astorije astorije added this to the 2.3.0 milestone Jan 31, 2017
@astorije
Copy link
Member

Does someone want to give a shot at migrating our config? @nornagon, are you willing to come back to us? :D

@astorije
Copy link
Member

From the channel:

bonuspunkt astorije the other thing was replace 'loaders' with 'rules'
bonuspunkt https://webpack.js.org/guides/migrating/#module-loaders-is-now-module-rules
+astorije Is the other change in your link necessary too?
+astorije I mean, s/loaders/rules/ sure, and the rest of the diff too?
bonuspunkt c&p from the doc >syntax is still valid and the old names are parsed. The new naming conventions are easier to understand and are a good reason to upgrade the configuration to using module.rules.
bonuspunkt the other stuff is chained loaders
bonuspunkt like for .styl you need to styl, css, style
+astorije bonuspunkt, feel free to post that on the PR :) The more I have to think about it, the more likely it'll get merged lol
bonuspunkt the link to the doc is already on the greenkeeper pr
bonuspunkt you might want to look into the UglifyJsPlugin notes in the doc

@xPaw
Copy link
Member

xPaw commented Feb 17, 2017

I've updated config according to the migration guide.

@@ -66,13 +70,11 @@ let config = {
// *********************************

if (process.env.NODE_ENV === "production") {
config.plugins.push(new webpack.optimize.DedupePlugin());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why did you remove this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}));
} else {
console.log("Building in development mode, bundles will not be minified.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Building for non-production, [...]"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds rather weird worded this way, imo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed but saying this is not production more accurate as we also have test env, etc.. Oh well, nitpick.

@astorije astorije merged commit f21a67b into master Feb 18, 2017
@astorije astorije deleted the greenkeeper/webpack-2.2.1 branch February 18, 2017 18:38
@astorije astorije modified the milestones: 2.2.2, 2.3.0 Feb 18, 2017
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
….2.1

Update webpack to the latest version 🚀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Dependencies Automatic updates for dependencies, managed by Renovate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants