Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author and description info in sidebar cannot display correctly [solved] #272

Closed
5 of 11 tasks
LinxinS97 opened this issue May 4, 2018 · 3 comments
Closed
5 of 11 tasks
Labels

Comments

@LinxinS97
Copy link

LinxinS97 commented May 4, 2018

I agree and want to create new issue


Expected behavior

The "author" and "description" in _config.yml info should be display in the sidebar

Actual behavior

"author" and "description" value in sidebar use the default value "John Doe" and "[empty]"
I've read the source code and found something strange at /next/layout/_macro/sidebar.swig

<div class="site-overview">
          <div class="site-author motion-element" itemprop="author" itemscope itemtype="http://schema.org/Person">
            {% if theme.avatar %}
              <img class="site-author-image" itemprop="image"
                src="{{ url_for( theme.avatar | default(theme.images + '/avatar.gif') ) }}"
                alt="{{ theme.author }}" />
            {% endif %}
              <p class="site-author-name" itemprop="name">{{ theme.author }}</p>
              <p class="site-description motion-element" itemprop="description">{#
            #}{% if theme.seo %}{#
              #}{{ theme.signature }}{#
            #}{% else %}{#
              #}{{ theme.description }}{#
            #}{% endif %}{#
            #}</p>
          </div>

it using the theme.author instead of config.author
after changed it into config.author and it can work properly

Steps to reproduce the behavior

  1. N/A
  2. N/A
  3. N/A
  • Link to demo site with this issue: N/A
  • Link(s) to source code or any usefull link(s): N/A

Node.js and NPM Information


Package dependencies Information


Hexo Information

Hexo version


Hexo Configuration

NexT Information

NexT Version:

  • Latest Master branch
  • Latest Release version
  • Old version

NexT Scheme:

  • All schemes
  • Muse
  • Mist
  • Pisces
  • Gemini

NexT Configuration:

Other Information

@ivan-nginx
Copy link
Member

I think this issue already fixed and will soon merged in #253 pull.
Can u confirm this?

@stale
Copy link

stale bot commented Jul 3, 2018

This issue has been automatically marked as stale because lack of recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Jul 3, 2018
@ivan-nginx ivan-nginx changed the title Author and description info in sidebar cannot display correctly Author and description info in sidebar cannot display correctly [solved] Mar 4, 2019
@lock
Copy link

lock bot commented Mar 10, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. It is possible issue was solved or at least outdated. Feel free to open new for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants