-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Music iframe do not follow the given width. #316
Comments
It can be controlled by the music iframe code.
|
@sli1989 I think you misunderstand my problem. |
Maybe you need quote in html attributes. <iframe frameborder="no" border="0" marginwidth="0" marginheight="0" width="330" height="450"
src="//music.163.com/outchain/player?type=0&id=739576121&auto=1&height=430"></iframe> |
@maple3142 Actually, that's the default iframe code of NetEase Music, and after add quote, the result is still unchange. |
@gapplef othe NexT schemes like Muse still have same bug? |
@ivan-nginx yes, all have the same problem. |
In hexo-theme-next/source/js/src/utils.js Lines 164 to 171 in 32d4a26
will solve the problem. It seems to be a feature rather than a bug 🤔 See: iissnan/hexo-theme-next@ccc18c7#diff-a85f8cc577970acb809c7250f9ae27e2 |
Maybe we can add option for 100% width or not here. |
@gapplef iframe of origin |
@stevenjoezhang thanks a lot. |
I agree and want to create new issue
I use the follow code to insert music iframe, and set width=330 height=450.
Expected behavior
This is the result with theme
tranquilpeak
, the width of music iframe is as expected.Actual behavior
When use theme
next
, the music iframe seems fit to the content width, and is much wider than the requirement.The text was updated successfully, but these errors were encountered: