-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar goes out of viewport after scroll down in custom page #846
Comments
What's the search service? |
I wrote a Google search crawler in python as backend, it collects the google searched page html content and send it back, then add the results into a container Actually, I found out the root cause seems to be dynamic height, try to render the following html and you can also reproduce it. <style>
#mydiv {
width: 10em;
height: 10em;
background: green;
}
</style>
<div id='mydiv' onclick="this.style.height='100em'"></div> |
@zq-97 I used your html code, but could not reproduce the problem... |
Indeed I have some custom css but it's all about color and font, nothing to do with layout. |
Sidebar position is controlled by https://github.com/theme-next/hexo-theme-next/blob/master/source/js/affix.js
|
The backends failed to work, so please don't take that page for reproduce. <style>
#mydiv {
width: 10em;
height: 10em;
background: green;
}
</style>
<div id='mydiv' onclick="this.style.height='100em'"></div> |
@stevenjoezhang I've updated to v7.30 but not work,
|
I just noticed that #1039 is not merged till now, after a manual fix and the problem solved! |
I'm glad the problem is solved.. I'll merge #1039 after further confirmation |
Fixed in next-theme/hexo-theme-next@b9968b6 |
I agree and want to create new issue
Expected behavior
After scolling down in some page, the side bar should fix on the side top.
I thought it is because
.sidebar-inner.affix
works.Actual behavior
But for my custom page, the sidebar goes outside the viewport after scrolldown.
Steps to reproduce the behavior
Please go to my custom page and search anything, when results appeared, scroll down the page, you'll see the sidebar will goes out.
Node.js and NPM Information
Package dependencies Information
Hexo Information
Hexo version
NexT Information
NexT Version:
NexT Scheme:
The text was updated successfully, but these errors were encountered: