Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FontAwesome 5 or custom .svg files #94

Closed
maddovr opened this issue Jan 29, 2018 · 6 comments
Closed

Use FontAwesome 5 or custom .svg files #94

maddovr opened this issue Jan 29, 2018 · 6 comments

Comments

@maddovr
Copy link

maddovr commented Jan 29, 2018

FontAwesome 5 has been released with many new icons even in the free version(e.g: discord icon was added which is quite good for the social bar). However I would also like to suggest the option to use custom .svg files specifying a path.

@ivan-nginx
Copy link
Member

ivan-nginx commented Jan 30, 2018

Is it paid version?

@maddovr
Copy link
Author

maddovr commented Jan 30, 2018

No, it's in the free version https://fontawesome.com/icons?d=gallery&q=discord&m=free

@ivan-nginx ivan-nginx mentioned this issue Jan 31, 2018
72 tasks
@maddovr
Copy link
Author

maddovr commented Jan 31, 2018

To update a bit, it's not possible to use the CDN version of FontAwesome5 either, so there must be some compatibility changes from 4.x to 5.x

@maddovr
Copy link
Author

maddovr commented Feb 5, 2018

So, a bit of an update: I've looked into upgrading from version 4 to version 5 and a regular upgrade is as trivial as modifying the default fa prefix in the configuration files(I think only next/layout folder is relevant for this). However since new color schemes are in the timeline, I think a refactor of how fontawesome is being invoked should be taken into consideration due to the new features fontawesome 5 offers(more info here: https://fontawesome.com/how-to-use/svg-with-js#additional-styling), and that's not trivial. At least, I don't see an easy way to do so.

@maddovr
Copy link
Author

maddovr commented Feb 22, 2018

Not a proper upgrade, but we could use the v4 shim as described here as a temporary solution.

@ivan-nginx
Copy link
Member

This issue will be closed in accordance with #505 issue.

@theme-next theme-next locked as resolved and limited conversation to collaborators Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants