Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected broken picture appears in sidebar. #975

Closed
5 of 11 tasks
Liam0205 opened this issue Jul 16, 2019 · 7 comments
Closed
5 of 11 tasks

Unexpected broken picture appears in sidebar. #975

Liam0205 opened this issue Jul 16, 2019 · 7 comments

Comments

@Liam0205
Copy link
Contributor

I agree and want to create new issue


Expected behavior

image

Actual behavior

image

Steps to reproduce the behavior

  1. merge latest commits (Cache sidebar site-overview #971 ) into local NexT theme directory.
  2. execute hexo s to run local server.
  3. check the side bar.
  • Link to demo site with this bug: N/A
  • Link(s) to source code or any usefull link(s): N/A

Node.js and NPM Information

$ node -v && npm -v
v10.13.0
6.4.1

Package dependencies Information

{
  "name": "hexo-site",
  "version": "0.0.0",
  "private": true,
  "hexo": {
    "version": "3.8.0"
  },
  "dependencies": {
    "dtrace-provider": "^0.8.7",
    "hexo": "^3.8.0",
    "hexo-deployer-git": "^0.3.1",
    "hexo-generator-archive": "^0.1.5",
    "hexo-generator-category": "^0.1.3",
    "hexo-generator-feed": "^1.2.2",
    "hexo-generator-index": "^0.2.1",
    "hexo-generator-searchdb": "^1.0.8",
    "hexo-generator-sitemap": "^1.2.0",
    "hexo-generator-tag": "^0.2.0",
    "hexo-renderer-ejs": "^0.3.1",
    "hexo-renderer-marked": "^0.3.2",
    "hexo-renderer-stylus": "^0.3.3",
    "hexo-server": "^0.3.1",
    "hexo-symbols-count-time": "^0.4.4"
  }
}

Hexo Information

Hexo version

$ hexo -v
hexo: 3.8.0
hexo-cli: 1.1.0
os: Windows_NT 6.1.7601 win32 x64
http_parser: 2.8.0
node: 10.13.0
v8: 6.8.275.32-node.36
uv: 1.23.2
zlib: 1.2.11
ares: 1.14.0
modules: 64
nghttp2: 1.34.0
napi: 3
openssl: 1.1.0i
icu: 62.1
unicode: 11.0
cldr: 33.1
tz: 2018e

Hexo Configuration

See #658 .

NexT Information

NexT Version:

  • Latest Master branch
  • Latest Release version
  • Old version

NexT Scheme:

  • All schemes
  • Muse
  • Mist
  • Pisces
  • Gemini

Note: I didn't test for other schemes.

NexT Configuration:

See #658 .

Other Information

Browser: Chrome 75.0.3770.142
System: macOS 14, Windows7

@Liam0205 Liam0205 added the Bug label Jul 16, 2019
@jiangtj
Copy link
Member

jiangtj commented Jul 16, 2019

I can't reproduce. Orz
image
image
What's this? avatar?

@Liam0205
Copy link
Contributor Author

@jiangtj

It seems to be a custom logo image.

image

@jiangtj
Copy link
Member

jiangtj commented Jul 16, 2019

image

This maybe work well.

Can you check custom_logo in theme config.
image

@Liam0205
Copy link
Contributor Author

Hmmmm...

I've figured it out. This is because the incompatibility introduced by #965 . mimi refactored the theme config file, and the relative part of custom_logo was changed from

custom_logo:
  enbale: false
  image: 

to

custom_logo: # invalid path

however, I copied the following snippet into source/_data/next.yml, which eventually causes the problem.

custom_logo:
  enbale: false
  image: 

@jiangtj
Copy link
Member

jiangtj commented Jul 16, 2019

image
#965 Yeah, breaking change in here.

@Liam0205
Copy link
Contributor Author

Based on the above discussion, this issue could be closed.

@support
Copy link

support bot commented Jul 30, 2019

👋 @Liam0205, we use the issue tracker exclusively for bug reports and feature requests. However, this issue appears to be a support request. Please use our support channels to get help with the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants