Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover click Not working on iphone safari #413

Closed
hotchilipowder opened this issue Jan 16, 2023 · 2 comments
Closed

Popover click Not working on iphone safari #413

hotchilipowder opened this issue Jan 16, 2023 · 2 comments
Assignees
Labels
bug Something isn't working v1.6.3 Issues and tasks for v1.6.3 release

Comments

@hotchilipowder
Copy link

hotchilipowder commented Jan 16, 2023

Describe the bug
The component of click popover is not working on iPhone 12 Safari.

Steps to reproduce the behavior:

  1. Go to triggering
  2. Click on 'click popover'
  3. See the error that "the popover" cannot disappear by doing click other places.

Expected behavior
The popover content can disappear after clicking other places.

Screenshots
IMG_9935

Smartphone (please complete the following information):

  • Device: [iPhone12]
  • OS: [e.g. iOS16.2]
  • Browser [safari]
  • Version [Mozilla/5.0 (iPhone; CPU iPhone OS 16_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.2 Mobile/15E148 Safari/604.]
@zoltanszogyenyi zoltanszogyenyi added bug Something isn't working v1.6.3 Issues and tasks for v1.6.3 release labels Jan 16, 2023
@zoltanszogyenyi zoltanszogyenyi self-assigned this Jan 16, 2023
@zoltanszogyenyi
Copy link
Member

Hello @hotchilipowder,

Thanks for the report - I'll have this checked out in the next few days. You're also free to open a PR if you'd like to contribute to help speed things up. The functionality for the Popover component is mostly found in this file:

https://github.com/themesberg/flowbite/blob/main/src/components/popover/index.ts

Cheers,
Zoltan

@zoltanszogyenyi
Copy link
Member

Hey @hotchilipowder,

I've fixed this issue (9610965) by handling the click outside of the element - the reason this happened is because Safari does not support focus and blur states on the button element.

This will be introduced with v1.6.3 of Flowbite.

Cheers,
Zoltan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.6.3 Issues and tasks for v1.6.3 release
Projects
None yet
Development

No branches or pull requests

2 participants