Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #14

Open
kirijiri opened this issue Aug 5, 2020 · 3 comments
Open

Windows support #14

kirijiri opened this issue Aug 5, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@kirijiri
Copy link
Contributor

kirijiri commented Aug 5, 2020

Wiz currently works on Linux and Mac, but not on windows. It should work cross platform.

@kirijiri kirijiri added the enhancement New feature or request label Aug 5, 2020
@kirijiri
Copy link
Contributor Author

kirijiri commented Aug 5, 2020

Looks like 'pwd' (https://docs.python.org/2/library/pwd.html) is only for linux and does not have a good alternative on windows. We might have to write something to retrieve the full user name ourselves in both platforms.

The 'termios' library also only exists for Unix (https://docs.python.org/2/library/termios.html). There is a TermiWin (https://github.com/ChristianVisintin/termiWin) but it even states that it should only be used when you don't need performance and high reliability.
Taking termios out makes the wiz shell spawn on windows.

@buddly27 buddly27 added this to the 3.1.0 milestone Aug 6, 2020
@kirijiri
Copy link
Contributor Author

Since there does not seem to be a an appropriate substitute for termios (pty in particular) on windows, I've been checking how Rez got its windows shell and found this thread: AcademySoftwareFoundation/rez#55
Looks like rez shells are plugins: https://github.com/nerdvegas/rez/tree/master/src/rezplugins/shell

For windows only CMD and PowerShell are supported in Rez:
https://github.com/nerdvegas/rez/blob/99e0ddb0f501d8efaaf7fc524b11db5244f67abb/src/rezplugins/shell/powershell.py
https://github.com/nerdvegas/rez/blob/663efc277924bdb353c85869585132f4191b703e/src/rezplugins/shell/cmd.py

There does not seem to be windows support for bash, which is what Wiz uses in unix right now:
https://github.com/nerdvegas/rez/blob/676a6236a51f2207267c91722328a682b76802aa/src/rezplugins/shell/bash.py#L91

@buddly27
Copy link
Contributor

Dropping the issue from the milestones 3.1.0, it's gonna come with the following version

@buddly27 buddly27 removed this from the 3.1.0 milestone Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants