feat: Add each-assertions. #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 24, 2022 12:21
The order of the assertions when building up the assert function was wrong. It is now ordered from less specific to more specific, so that the most specific assertions are always used.
This includes a major rewrite of the types and structure of the top level assert.that function to achieve re-use of the existing assertions and keep outward type-safety. This unfortunately breaks the internal type-safety of assertthat and makes maintenance of the combined assertions harder.
yeldiRium
requested review from
dotKuro,
goloroden and
strangedev
as code owners
goloroden
requested changes
Jan 25, 2022
Co-authored-by: Golo Roden <golo.roden@thenativeweb.io>
goloroden
previously approved these changes
Feb 10, 2022
|
@yeldiRium Basically, I'm fine with this 👍 Besides that, from my POV, we're good to go 😊 |
|
@goloroden I've seen it now and bumped the year to 2022 :) |
goloroden
previously approved these changes
Feb 10, 2022
|
@yeldiRium Thanks 😊 From my side, this is fine. I've approved the PR, but didn't want to merge it, because I did not know whether you wanted to also have feedback from someone else. If you are fine with this, please feel free to merge. 😊 |
strangedev
suggested changes
Feb 22, 2022
lib/assertions/combined/negated/assertActualIsNotThrowingAsync.ts
Outdated
Show resolved
Hide resolved
strangedev
reviewed
Feb 22, 2022
strangedev
previously approved these changes
Mar 22, 2022
|
Awesome 😍 |
dotKuro
previously approved these changes
Mar 22, 2022
goloroden
requested changes
Mar 22, 2022
There was a problem hiding this comment.
@yeldiRium The changes look really great 👍
However, the documentation is not yet up-to-date (although this is just a small change). Could you please adjust this?
goloroden
approved these changes
Mar 22, 2022
goloroden
pushed a commit
that referenced
this pull request
Mar 22, 2022
# [6.5.0](6.4.0...6.5.0) (2022-03-22) ### Features * Add each-assertions. ([#408](#408)) ([0bcaac6](0bcaac6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a major rewrite of the types and structure of the top
level assert.that function to achieve re-use of the existing assertions
and keep outward type-safety.
This unfortunately breaks the internal type-safety of assertthat and
makes maintenance of the combined assertions harder.