Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dynamodb implementation for domain and viewmodel #97

Open
yacut opened this issue Jul 6, 2017 · 5 comments
Open

Adding dynamodb implementation for domain and viewmodel #97

yacut opened this issue Jul 6, 2017 · 5 comments

Comments

@yacut
Copy link

yacut commented Jul 6, 2017

Hallo.

The eventstore package has support for DynamoDB one year already (thenativeweb/node-eventstore#75).

Is it possible to add DynamoDB to domain and viewmodel packages?

@adrai
Copy link
Contributor

adrai commented Jul 6, 2017

cqrs-domain already uses the newest evenstore dependency (incl. dynamodb).
But perhaps there is a need for bumper and aggregateLock to have a dynamodb implementation too?
And viewmodel has no dynamodb implementation right now...
So yes, feel free to submit a PR... ;-)

@emmkong
Copy link
Contributor

emmkong commented Aug 11, 2017

@yacut the aggregateLock and viewmodel support dynamodb now. Please have a look and feed back to me if you found anything issue. Thanks.

@Glockenbeat
Copy link
Contributor

@emmkong I'm currently implementing the package using DynamoDB as an endpoint. So far it seems to be working alright, however when initializing the DocumentClient the configuration values are not correctly passed. I've created PRs for each package which should fix this.

Thank you and thank you @yacut for your effort on this!

@adrai
Copy link
Contributor

adrai commented Aug 31, 2017

@Glockenbeat all merged ;-)

@Glockenbeat
Copy link
Contributor

Thanks a lot for the quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants