-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropping support for node 4 #64
Comments
dropping support, yes. |
Just an idea, couldn't we check node version if plugin is initialized ( process.version ), and then output an appropriate warning/error message just for this plugin? |
can do this also for all plugins and check the engines value in the appropriate package.json => https://github.com/googleapis/nodejs-firestore/blob/master/package.json#L8 |
much better! |
I just created a branch: https://github.com/adrai/node-viewmodel/compare/warn-version-mismatch |
Are you guys open to the idea of dropping support for node4? I ask because of a couple of reasons.
Thoughts?
The text was updated successfully, but these errors were encountered: