Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping support for node 4 #64

Open
rickerbh opened this issue Aug 17, 2018 · 6 comments
Open

Dropping support for node 4 #64

rickerbh opened this issue Aug 17, 2018 · 6 comments
Labels

Comments

@rickerbh
Copy link

Are you guys open to the idea of dropping support for node4? I ask because of a couple of reasons.

  1. On 30 April 2018 node 4 hit end of life, and node.js themselves no longer support it. https://github.com/nodejs/Release
  2. Firestore requires node>=6.0.0, and the firestore plugin I've developed won't work with node4.

Thoughts?

@adrai
Copy link
Contributor

adrai commented Aug 17, 2018

dropping support, yes.
but this should not mean, it should not run with node 4...
just my opinion

@nanov
Copy link
Contributor

nanov commented Aug 18, 2018

Just an idea, couldn't we check node version if plugin is initialized ( process.version ), and then output an appropriate warning/error message just for this plugin?

@adrai
Copy link
Contributor

adrai commented Aug 18, 2018

can do this also for all plugins and check the engines value in the appropriate package.json

=> https://github.com/googleapis/nodejs-firestore/blob/master/package.json#L8

@nanov
Copy link
Contributor

nanov commented Aug 18, 2018

much better!

@adrai
Copy link
Contributor

adrai commented Aug 18, 2018

@rickerbh ?

@adrai
Copy link
Contributor

adrai commented Aug 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants