Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-strict dependency test crashes when non-strict dependencies are found #464

Closed
yeldiRium opened this issue Dec 4, 2020 · 0 comments · Fixed by #465
Closed

Non-strict dependency test crashes when non-strict dependencies are found #464

yeldiRium opened this issue Dec 4, 2020 · 0 comments · Fixed by #465
Assignees
@yeldiRium
Labels
Bug

Comments

@yeldiRium
Copy link
Contributor

The check for non-strict dependencies does what it is supposed to do, but it crashes when reporting that non-strict dependencies were found.

roboter/lib/cli/tasks/dependencies.js

Line 34 in f40b16e

throw new errors.NonStrictDependenciesFound();

roboter/lib/errors.js

Line 22 in f40b16e

NonStrictDependencyFound: {},

We try to instantiate an error that does not exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yeldiRium yeldiRium

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use correct error constructor when non-strict dependencies are found. thenativeweb/roboter
1 participant
@yeldiRium