feat: check license against SPDX license list #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goloroden
previously approved these changes
Aug 24, 2021
goloroden
approved these changes
Aug 24, 2021
goloroden
pushed a commit
that referenced
this pull request
Aug 24, 2021
# [12.2.0](12.1.3...12.2.0) (2021-08-24) ### Features * check license against SPDX license list ([#701](#701)) ([6125043](6125043))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds validation of the package's license against the SPDX license list. Previously, we enforced a list of allowed license IDs that is defined by https://github.com/thenativeweb/npm-package-json-lint-config-tnw. This has proven unpractical, as many license may be used and we can't provide useful defaults for everyone. We decided against enforcing a specific set of licenses and are instead focusing on SPDX now. This is mainly to guard against typos and deprecation. The roboter will now check the package's license against the list of SPDX license IDs during its
qastep. The default behavior is to reject non-SPDX licenses, as well as deprecated licenses. Both can be disabled on a per-project basis using thelicenseCheck.jsonconfiguration file.