Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong CV Config Response #134

Closed
tomijaga opened this issue Apr 9, 2021 · 0 comments · Fixed by #133
Closed

Wrong CV Config Response #134

tomijaga opened this issue Apr 9, 2021 · 0 comments · Fixed by #133
Assignees
Labels
Paid PR Reward - 100 Reward in coin(s)

Comments

@tomijaga
Copy link
Contributor

tomijaga commented Apr 9, 2021

Describe the bug
The Confirmation Validator Config Response is wrong

To Reproduce
Steps to reproduce the behavior:
https://github.com/thenewboston-developers/thenewboston-js/blob/master/src/models/responses/confirmation-validator/config.ts

Expected behavior

export interface PrimaryValidatorConfigResponse {
  primary_validator: {
    account_number: Hex;
    ip_address: Origin;
    node_identifier: Hex;
    port: Port | null;
    protocol: Protocol;
    version: Version;
    default_transaction_fee: number;
    root_account_file: Url;
    root_account_file_hash: Hex;
    seed_block_identifier: Hex;
    daily_confirmation_rate: number | null;
    trust: Trust;
  };
  account_number: Hex;
  ip_address: Origin;
  node_identifier: Hex;
  port: Port | null;
  protocol: Protocol;
  version: Version;
  default_transaction_fee: number;
  root_account_file: Url;
  root_account_file_hash: Hex;
  seed_block_identifier: Hex;
  daily_confirmation_rate: number;
  node_type: NodeType;
}

** Pull Requests **
All Pull Request should be made against development branch read contributors guide for more information about contributing

@zinoadidi zinoadidi linked a pull request Apr 9, 2021 that will close this issue
@zinoadidi zinoadidi added the PR Reward - 100 Reward in coin(s) label Apr 9, 2021
@zinoadidi zinoadidi added the Paid label May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paid PR Reward - 100 Reward in coin(s)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants