-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task] Scope npm package to @thenewboston/sdk #139
Comments
if that's just a renaming issue i could do that... |
@angle943 what do you think about the naming convention |
I'm just looking at how Sentry names its client side libraries (across different platforms). https://docs.sentry.io/platforms/javascript/
|
@denistsoi @zinoadidi yeah i agree, we should rename this. tagging @buckyroberts EDIT: i don't think it should be @thenewboston/sdk though, since we will have multiple sdk libraries. Perhaps @thenewboston/js, @thenewboston/js-sdk, or @thenewboston/sdk/js? |
Perhaps npm supports TS/JS - however, i dont suspect us using something like WASM to be deployed via npm (tho a possibility)
|
I like |
@buckyroberts awaiting input from you :) |
i'm down actually for @thenewboston/js-sdk |
Task
Contributors are able to complete this task and earn thenewboston coins. Check out the labels to learn how much you can earn for contributing by completing this task. Please make sure to be honest if you wish to contribute by saying you can't finish this and we can just un-assign you with no harm done! There is no point in delaying tasks from being completed for miscommunication!
Overview
since there may be other npm packages by thenewboston org, it may be beneficial to scope this package with “@thenewboston”.
Behavior
Rename name in package.Json from “thenewboston” to “@thenewboston/sdk”
/* code examples are awesome */
Please ask for this task to be assigned to you and earn and its sweet reward 😉
Remember to include your account number in your PR description for us to pay you 💰
** Pull Requests **
All Pull Request should be made to development branch, read contributors guild for more information about contributing
The text was updated successfully, but these errors were encountered: