Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minified file not in releases #148

Open
AbhayAysola opened this issue Apr 13, 2021 · 5 comments
Open

minified file not in releases #148

AbhayAysola opened this issue Apr 13, 2021 · 5 comments
Labels
Not Ready Task is not ready for development

Comments

@AbhayAysola
Copy link
Contributor

Describe the bug
The minified tnb.min.js file is not included in the releases.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/thenewboston-developers/thenewboston-js/releases
  2. See that the min file is not included in the assets

Expected behavior
I expected the min file to be included.

** Pull Requests **
All Pull Request should be made against development branch read contributors guide for more information about contributing

@zinoadidi
Copy link
Contributor

do we want to include minified file or release only minified file @AbhayAysola

@zinoadidi zinoadidi added the Not Ready Task is not ready for development label Apr 13, 2021
@AbhayAysola
Copy link
Contributor Author

do we want to include minified file or release only minified file @AbhayAysola

I think we should include the minified file. A seperate release might be too confusing for new developers

@zinoadidi
Copy link
Contributor

zinoadidi commented Apr 13, 2021

This brings us to a wider topic as at the moment github released are created manually not part of the existing automated actions that publishes the new npm version

For this to be added without having to do manually 1 additional step, we need to automate github release process so it builds / minifies project then create the release along with changelog and etc

@AbhayAysola
Copy link
Contributor Author

This brings us to a wider topic as at the moment github released are created manually not part of the existing automated actions that publishes the new npm version

For this to be added without having to do manually 1 additional step, we need to automate github release process so it builds / minifies project then create the release along with changelog and etc

Hmm that could be done, I'll close this issue in favour of automating releases in the future.

@zinoadidi
Copy link
Contributor

I think we csn keep it open and link it to the automation task when it will be opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not Ready Task is not ready for development
Projects
None yet
Development

No branches or pull requests

2 participants