We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The protocol field in NetworkNode model should not be null or empty. It should have the default set as 80.
Reason, IP, protocol, port 1.1.1.1, HTTP, null 1.1.1.1, HTTP, 80 will be 2 different nodes, for the system, while in reality its the same node
Also, there should be a data migration in Validator and Bank projects to replace null or empty fields with default 80
https://github.com/thenewboston-developers/thenewboston-python/blob/development/src/thenewboston/models/network_node.py#L14
The text was updated successfully, but these errors were encountered:
@buckyroberts #53 Account Number: 38a99b8f1916eab0471ca1df26e7fe5e71d845e6ea5b233cd3d93a75097ea2d6
Sorry, something went wrong.
@vosi @buckyroberts please DM me when this has been completed & merge
dmugtasimov
No branches or pull requests
The protocol field in NetworkNode model should not be null or empty. It should have the default set as 80.
Reason,
IP, protocol, port
1.1.1.1, HTTP, null
1.1.1.1, HTTP, 80
will be 2 different nodes, for the system, while in reality its the same node
Also, there should be a data migration in Validator and Bank projects to replace null or empty fields with default 80
https://github.com/thenewboston-developers/thenewboston-python/blob/development/src/thenewboston/models/network_node.py#L14
The text was updated successfully, but these errors were encountered: