Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Replaced startCrawl and stopCrawl return types #136

Merged
merged 3 commits into from
Apr 10, 2021
Merged

Fix: Replaced startCrawl and stopCrawl return types #136

merged 3 commits into from
Apr 10, 2021

Conversation

tomijaga
Copy link
Contributor

@tomijaga tomijaga commented Apr 10, 2021 •
edited
Loading

I made a mistake in the crawl methods for both the bank and validator class.
The crawl response was set to type CleanResponse instead of Crawlresponse.
I have replaced them with this PR.

Pls @zinoadidi when you have time update the npm package.

@tomijaga tomijaga changed the base branch from master to development April 10, 2021 00:52
@zinoadidi zinoadidi changed the title Replaced startCrawl and stopCrawl return types Fix: Replaced startCrawl and stopCrawl return types Apr 10, 2021
@zinoadidi zinoadidi merged commit 9f05092 into thenewboston-blockchain:development Apr 10, 2021
@tomijaga tomijaga deleted the crawlFix branch April 10, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zinoadidi zinoadidi zinoadidi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomijaga @zinoadidi