Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Account.isValidPair throwing on invalid seeds #152

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

sno2
Copy link
Contributor

@sno2 sno2 commented Apr 20, 2021

Description

The issue was that Account.isValidPair was throwing errors when the seed inputs were not of valid lengths or were not actual hex characters. This PR fixes that issue and implements tests to ensure this behavior stays fixed.

Fixes #151

Type of change

  • Chore (chore: description-of-task)
  • Fix (fix: description-of-fix)
  • Feature (feat: description-of-fix)
  • Test (test: description-of-tests-performed)
  • Docs (docs: description-of-docs-added-or-modified)
  • Refactor (refactor: description-of-refactor)

Please specify the type of change in your title following the above format

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@zinoadidi zinoadidi self-requested a review April 22, 2021 15:43
@zinoadidi zinoadidi merged commit 1a18fad into thenewboston-blockchain:development Apr 22, 2021
@zinoadidi
Copy link
Contributor

@sno2 your account number #tnbc

@sno2
Copy link
Contributor Author

sno2 commented May 30, 2021

@sno2 your account number #tnbc

d84543947090d300910f8d1b9604c0c0a56fafca6cfbe52511c1e31757188bca Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Account.isValidPair throwing errors on invalid seed lengths and seed chars
2 participants