feat: Get bank pv #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
zinoadidi
suggested changes
Mar 29, 2021
src/bank.ts
Outdated
| * Gets the PrimaryValidator for the current bank. | ||
| */ | ||
| async getBankPV() { | ||
| const { primary_validator } = await await this.getConfig(); |
There was a problem hiding this comment.
this looks like a new way to write awaits, does it work?
There was a problem hiding this comment.
Haha I accidentally wrote await twice, my bad 😅. Not sure how I missed that
|
test bank class task created #90 |
|
Hey, @AbhayAysola can we have the |
Done |
tomijaga
reviewed
Mar 29, 2021
|
@zinoadidi The PR looks good! |
|
Thanks @tomijaga, @AbhayAysola |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84
Account Number: 8928526805de48e4bf2ed2a9b4b839e6b2603018ecdfbf4cffdb2065e01a3ed1