Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added getCrawlStatus #91

Merged
merged 5 commits into from
Mar 29, 2021

Conversation

tomijaga
Copy link
Contributor

@tomijaga tomijaga commented Mar 29, 2021

Resolves: #85
Resolves: #95

@tomijaga
Copy link
Contributor Author

Having errors when making crawl post request

This is the crawl documentation
image

It says you only need the data and signature keys, but when i call the startCrawl() method i get an error that says i need to add the nodeIdentifier property
image

@zinoadidi
Copy link
Contributor

@tomijaga I was looking at the account manager,
it seems to be doing a lot more things;
could it be that we are missing something that they are doing there?

@zinoadidi zinoadidi self-requested a review March 29, 2021 07:32
Copy link
Contributor

@zinoadidi zinoadidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting response

@tomijaga
Copy link
Contributor Author

tomijaga commented Mar 29, 2021

@zinoadidi I only added the functions that were related to thenewboston or that directly called the API. Most of the functions there are specific to the Account Manager.

You can double check to see if there is anything missing. There is always a possibility that i might have missed or skipped something.
I also left a comment on the account manager repo for @angle943 so that he could check if the document had covered all the functionalities

@zinoadidi
Copy link
Contributor

@tomijaga lets keep it open until we have further clarification.
thanks for your efforts!

@zinoadidi zinoadidi linked an issue Mar 29, 2021 that may be closed by this pull request
@tomijaga
Copy link
Contributor Author

Post request structure is wrong. Should be:

message:{
    crawl: "start" | "stop"
},
node_identifier: 565723676...,
signature: 54cd54bvd...

Solution can be found here: https://github.com/thenewboston-developers/Account-Manager/blob/master/src/renderer/hooks/useCleanSockets.tsx

@zinoadidi
Copy link
Contributor

Good job finding it!.
When you have time do update the solution so we can close it

@zinoadidi zinoadidi changed the title added getCrawlStatus feat: added getCrawlStatus Mar 29, 2021
@zinoadidi zinoadidi merged commit 409d559 into thenewboston-blockchain:development Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Implement craw functionality (feature | tests | docs)
2 participants